Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop hardcoding editors' names #833

Merged
merged 1 commit into from
Aug 30, 2024
Merged

stop hardcoding editors' names #833

merged 1 commit into from
Aug 30, 2024

Conversation

maelle
Copy link
Member

@maelle maelle commented Aug 16, 2024

No description provided.

@maelle maelle requested a review from mpadge August 16, 2024 12:02
@maelle maelle marked this pull request as draft August 16, 2024 12:31
@maelle
Copy link
Member Author

maelle commented Aug 16, 2024

I need to align this with software review

@maelle
Copy link
Member Author

maelle commented Aug 16, 2024

or can we view this as good enough for now, I'd tackle #834 another time

mpadge
mpadge approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, "good enough for now", but then we need to do #834

@maelle maelle marked this pull request as ready for review August 30, 2024 08:04
@maelle maelle merged commit 36fef51 into main Aug 30, 2024
2 checks passed
@maelle maelle deleted the editoras branch August 30, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpadge mpadge mpadge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maelle @mpadge